Skip to content

refactor: update sync model helper function docs and minor cleanup#36645

Merged
bradenmacdonald merged 1 commit intoopenedx:release/teak.masterfrom
open-craft:navin/fal-4077/backport/follow-up
May 1, 2025
Merged

refactor: update sync model helper function docs and minor cleanup#36645
bradenmacdonald merged 1 commit intoopenedx:release/teak.masterfrom
open-craft:navin/fal-4077/backport/follow-up

Conversation

@navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented May 1, 2025 •
edited
Loading

Description

Backport of #36599

Supporting information

#36599

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 1, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented May 1, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 1, 2025
@navinkarkera navinkarkera changed the title refactor: update sync model helper function docs and minor cleanup (#… refactor: update sync model helper function docs and minor cleanup May 1, 2025
@navinkarkera
refactor: update sync model helper function docs and minor cleanup (o…
507d9ac 
…penedx#36599)

* refactor: update sync model helper function docs

Adds some comments to explain certain confusing sections

* refactor: sync library content method

* feat: use edited_on block field

* test: modified field in course block index

* fix: extract uncommon methods to child class from base

(cherry picked from commit c2d9e40)
@navinkarkera navinkarkera force-pushed the navin/fal-4077/backport/follow-up branch from e0df512 to 507d9ac Compare May 1, 2025 06:30
@navinkarkera navinkarkera mentioned this pull request May 1, 2025
Merged
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions May 1, 2025
bradenmacdonald
bradenmacdonald approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to be working well. Thanks for backporting.

@farhaanbukhsh FYI on backport fix.

@bradenmacdonald bradenmacdonald merged commit 75b4b84 into openedx:release/teak.master May 1, 2025
48 checks passed
@bradenmacdonald bradenmacdonald deleted the navin/fal-4077/backport/follow-up branch May 1, 2025 22:27
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

@pomegranited pomegranited Awaiting requested review from pomegranited

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@navinkarkera @openedx-webhooks @bradenmacdonald